/[base]
ViewVC logotype

Revision 361112


Jump to revision: Previous Next
Author: jilles
Date: Sat May 16 16:29:23 2020 UTC (4 years, 1 month ago)
Changed paths: 3
Log Message:
sh: Fix double INTON with vfork

The shell maintains a count of the number of times SIGINT processing has
been disabled via INTOFF, so SIGINT processing resumes when all disables
have enabled again (INTON).

If an error occurs in a vfork() child, the processing of the error enables
SIGINT processing again, and the INTON in vforkexecshell() causes the count
to become negative.

As a result, a later INTOFF may not actually disable SIGINT processing. This
might cause memory corruption if a SIGINT arrives at an inopportune time. As
of r360452, it causes the shell to abort when it would unsafely allocate or
free memory in certain ways.

Note that various places such as errors in non-special builtins
unconditionally reset the count to 0, so the problem might still not always
be visible.

PR:		246497
Reported by:	jbeich
MFC after:	2 weeks


Changed paths

Path Details
Directoryhead/bin/sh/jobs.c modified , text changed
Directoryhead/bin/sh/tests/execution/Makefile modified , text changed
Directoryhead/bin/sh/tests/execution/unknown2.0 added

  ViewVC Help
Powered by ViewVC 1.1.27