/[base]
ViewVC logotype

Revision 358955


Jump to revision: Previous Next
Author: 0mp
Date: Fri Mar 13 11:27:29 2020 UTC (4 years, 3 months ago)
Changed paths: 6
Log Message:
MFC 351481, 357619:

Approved by:	bcr (mentor), hselasky (src)
Differential Revision:	https://reviews.freebsd.org/D24058

mixer(8): Report an error if the passed value is an empty string

This patch fixes a bug that made the mixer command enter
an infinite loop when instructed to set the value of a device
to an empty string (e.g., `mixer vol ""`).

Additionally, some tests for mixer(8) are being added.

PR:		240039
Reviewed by:	hselasky, mav
Approved by:	src (hselasky, mav)
Differential Revision:	https://reviews.freebsd.org/D21409

mixer: call the cleanup function in a test

The set_empty_value test has a cleanup function, but is not called.
Fix it

Reviewed by:	0mp
Approved by:	kp
Differential Revision:	https://reviews.freebsd.org/D23498


Changed paths

Path Details
Directorystable/12/ modified , props changed
Directorystable/12/etc/mtree/BSD.tests.dist modified , text changed
Directorystable/12/usr.sbin/mixer/Makefile modified , text changed
Directorystable/12/usr.sbin/mixer/mixer.c modified , text changed
Directorystable/12/usr.sbin/mixer/tests/
(Copied from head/usr.sbin/mixer/tests, r351481)
added
Directorystable/12/usr.sbin/mixer/tests/mixer_test.sh modified , text changed

  ViewVC Help
Powered by ViewVC 1.1.27