/[base]
ViewVC logotype

Revision 341008


Jump to revision: Previous Next
Author: ae
Date: Tue Nov 27 09:04:06 2018 UTC (5 years, 7 months ago)
Changed paths: 2
Log Message:
Fix possible panic during ifnet detach in rtsock.

The panic can happen, when some application does dump of routing table
using sysctl interface. To prevent this, set IFF_DYING flag in
if_detach_internal() function, when ifnet under lock is removed from
the chain. In sysctl_rtsock() take IFNET_RLOCK_NOSLEEP() to prevent
ifnet detach during routes enumeration. In case, if some interface was
detached in the time before we take the lock, add the check, that ifnet
is not DYING. This prevents access to memory that could be freed after
ifnet is unlinked.

PR:		227720, 230498, 233306
Reviewed by:	bz, eugen
MFC after:	1 week
Sponsored by:	Yandex LLC
Differential Revision:	https://reviews.freebsd.org/D18338


Changed paths

Path Details
Directoryhead/sys/net/if.c modified , text changed
Directoryhead/sys/net/rtsock.c modified , text changed

  ViewVC Help
Powered by ViewVC 1.1.27