/[base]
ViewVC logotype

Revision 338216


Jump to revision: Previous Next
Author: asomers
Date: Wed Aug 22 23:31:27 2018 UTC (5 years, 10 months ago)
Changed paths: 1
Log Message:
tftpd: Fix data corruption bug with netascii

Transferring files in netascii format requires, among other things,
translating all CR characters to a CR,NUL pair. tftpd does this correctly
except when the CR occurs as the last octet of a packet. In that case, it
erroneously drops the NUL which should be part of the following packet. The
bug was caused by using 0 as a sentinel value in a variable that could
legitimately hold 0. Fix it by switching the sentinel value to -1.

PR:		178055
Reported by:	Richard <rsitze@gmail.com>
Reviewed by:	cem
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D16853


Changed paths

Path Details
Directoryhead/libexec/tftpd/tftp-file.c modified , text changed

  ViewVC Help
Powered by ViewVC 1.1.27