/[base]
ViewVC logotype

Revision 322582


Jump to revision: Previous Next
Author: kevans
Date: Wed Aug 16 17:38:37 2017 UTC (6 years, 10 months ago)
Changed paths: 8
Log Message:
MFC r317254: bsdgrep: add BSD_GREP_FASTMATCH knob for built-in fastmatch

Bugs have been found in the fastmatch implementation as used in bsdgrep.
Some have been fixed (r316495) while fixes for others are in review
(D10098).

In comparison with the fastmatch implementation, Kyle Evans found that:

- regex(3)'s performance with literal expressions offers a speed
  improvement over fastmatch

- regex(3)'s performance, both with simple BREs and EREs, seems to be
  comparable

The regex implementation was imported in r226035, and the commit message
reports:

    This is a temporary solution until the whole regex library is
    not replaced so that BSD grep development can continue and the
    backported code gets some review and testing. This change only
    improves scalability slightly, there is no big performance boost
    yet but several minor bugs have been found and fixed.

Introduce a WITH_/WITHOUT_BSD_GREP_FASTMATCH knob to support testing
of both approaches.

Regenerate src.conf(5) as per the original commit

PR:		175314, 194823
Approved by:	emaste (mentor, blanket MFC)


Changed paths

Path Details
Directorystable/11/ modified , props changed
Directorystable/11/share/man/man5/src.conf.5 modified , text changed
Directorystable/11/share/mk/src.opts.mk modified , text changed
Directorystable/11/tools/build/options/WITHOUT_BSD_GREP_FASTMATCH
(Copied from head/tools/build/options/WITHOUT_BSD_GREP_FASTMATCH, r317254)
added
Directorystable/11/usr.bin/grep/Makefile modified , text changed
Directorystable/11/usr.bin/grep/grep.c modified , text changed
Directorystable/11/usr.bin/grep/grep.h modified , text changed
Directorystable/11/usr.bin/grep/util.c modified , text changed

  ViewVC Help
Powered by ViewVC 1.1.27