/[base]
ViewVC logotype

Revision 311305


Jump to revision: Previous Next
Author: asomers
Date: Wed Jan 4 20:26:42 2017 UTC (7 years, 5 months ago)
Changed paths: 52
Log Message:
Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
fixed-length strings. AFAICT the only place they're read is in
sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
uses strncpy to write them, and doesn't guarantee null-termination. For at
least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
overflows. You can see the result by doing "camcontrol negotiate da0 -v".

This change null-terminates those fields everywhere they're set in the
kernel. It also shortens a few strings to ensure they'll fit within the
16-character field.

PR:		215474
Reported by:	Coverity
CID:		1009997 1010000 1010001 1010002 1010003 1010004 1010005
CID:		1331519 1010006 1215097 1010007 1288967 1010008 1306000
CID:		1211924 1010009 1010010 1010011 1010012 1010013 1010014
CID:		1147190 1010017 1010016 1010018 1216435 1010020 1010021
CID:		1010022 1009666 1018185 1010023 1010025 1010026 1010027
CID:		1010028 1010029 1010030 1010031 1010033 1018186 1018187
CID:		1010035 1010036 1010042 1010041 1010040 1010039
Reviewed by:	imp, sephe, slm
MFC after:	4 weeks
Sponsored by:	Spectra Logic Corp
Differential Revision:	https://reviews.freebsd.org/D9037
Differential Revision:	https://reviews.freebsd.org/D9038


Changed paths

Path Details
Directoryhead/sys/cam/cam_xpt.c modified , text changed
Directoryhead/sys/cam/ctl/ctl_frontend_cam_sim.c modified , text changed
Directoryhead/sys/cam/scsi/scsi_low.c modified , text changed
Directoryhead/sys/dev/aac/aac_cam.c modified , text changed
Directoryhead/sys/dev/aacraid/aacraid_cam.c modified , text changed
Directoryhead/sys/dev/advansys/advansys.c modified , text changed
Directoryhead/sys/dev/advansys/adwcam.c modified , text changed
Directoryhead/sys/dev/aha/aha.c modified , text changed
Directoryhead/sys/dev/ahb/ahb.c modified , text changed
Directoryhead/sys/dev/ahci/ahci.c modified , text changed
Directoryhead/sys/dev/ahci/ahciem.c modified , text changed
Directoryhead/sys/dev/aic/aic.c modified , text changed
Directoryhead/sys/dev/aic7xxx/aic79xx_osm.c modified , text changed
Directoryhead/sys/dev/aic7xxx/aic7xxx_osm.c modified , text changed
Directoryhead/sys/dev/amr/amr_cam.c modified , text changed
Directoryhead/sys/dev/arcmsr/arcmsr.c modified , text changed
Directoryhead/sys/dev/ata/ata-all.c modified , text changed
Directoryhead/sys/dev/buslogic/bt.c modified , text changed
Directoryhead/sys/dev/ciss/ciss.c modified , text changed
Directoryhead/sys/dev/dpt/dpt_scsi.c modified , text changed
Directoryhead/sys/dev/esp/ncr53c9x.c modified , text changed
Directoryhead/sys/dev/firewire/sbp.c modified , text changed
Directoryhead/sys/dev/firewire/sbp_targ.c modified , text changed
Directoryhead/sys/dev/hpt27xx/hpt27xx_osm_bsd.c modified , text changed
Directoryhead/sys/dev/hptiop/hptiop.c modified , text changed
Directoryhead/sys/dev/hptmv/entry.c modified , text changed
Directoryhead/sys/dev/hptnr/hptnr_osm_bsd.c modified , text changed
Directoryhead/sys/dev/hptrr/hptrr_osm_bsd.c modified , text changed
Directoryhead/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c modified , text changed
Directoryhead/sys/dev/iir/iir.c modified , text changed
Directoryhead/sys/dev/isci/isci_controller.c modified , text changed
Directoryhead/sys/dev/iscsi_initiator/isc_cam.c modified , text changed
Directoryhead/sys/dev/isp/isp_freebsd.c modified , text changed
Directoryhead/sys/dev/mfi/mfi_cam.c modified , text changed
Directoryhead/sys/dev/mly/mly.c modified , text changed
Directoryhead/sys/dev/mpr/mpr_sas.c modified , text changed
Directoryhead/sys/dev/mps/mps_sas.c modified , text changed
Directoryhead/sys/dev/mpt/mpt_cam.c modified , text changed
Directoryhead/sys/dev/mrsas/mrsas_cam.c modified , text changed
Directoryhead/sys/dev/mvs/mvs.c modified , text changed
Directoryhead/sys/dev/ncr/ncr.c modified , text changed
Directoryhead/sys/dev/nvme/nvme_sim.c modified , text changed
Directoryhead/sys/dev/pms/freebsd/driver/ini/src/agtiapi.c modified , text changed
Directoryhead/sys/dev/ppbus/vpo.c modified , text changed
Directoryhead/sys/dev/siis/siis.c modified , text changed
Directoryhead/sys/dev/sym/sym_hipd.c modified , text changed
Directoryhead/sys/dev/trm/trm.c modified , text changed
Directoryhead/sys/dev/twa/tw_osl_cam.c modified , text changed
Directoryhead/sys/dev/tws/tws_cam.c modified , text changed
Directoryhead/sys/dev/virtio/scsi/virtio_scsi.c modified , text changed
Directoryhead/sys/powerpc/ps3/ps3cdrom.c modified , text changed
Directoryhead/sys/powerpc/pseries/phyp_vscsi.c modified , text changed

  ViewVC Help
Powered by ViewVC 1.1.27