/[base]
ViewVC logotype

Revision 279912


Jump to revision: Previous Next
Author: ae
Date: Thu Mar 12 09:16:50 2015 UTC (9 years, 3 months ago)
Changed paths: 5
Log Message:
MFC r279588:
  Fix deadlock in IPv6 PCB code.

  When several threads are trying to send datagram to the same destination,
  but fragmentation is disabled and datagram size exceeds link MTU,
  ip6_output() calls pfctlinput2(PRC_MSGSIZE). It does notify all
  sockets wanted to know MTU to this destination. And since all threads
  hold PCB lock while sending, taking the lock for each PCB in the
  in6_pcbnotify() leads to deadlock.

  RFC 3542 p.11.3 suggests notify all application wanted to receive
  IPV6_PATHMTU ancillary data for each ICMPv6 packet too big message.
  But it doesn't require this, when we don't receive ICMPv6 message.

  Change ip6_notify_pmtu() function to be able use it directly from
  ip6_output() to notify only one socket, and to notify all sockets
  when ICMPv6 packet too big message received.

MFC r279684:
  tcp6_ctlinput() doesn't pass MTU value to in6_pcbnotify().
  Check cmdarg isn't NULL before dereference, this check was in the
  ip6_notify_pmtu() before r279588.

PR:		197059
Sponsored by:	Yandex LLC


Changed paths

Path Details
Directorystable/9/sys/ modified , props changed
Directorystable/9/sys/netinet6/in6_pcb.c modified , text changed
Directorystable/9/sys/netinet6/ip6_input.c modified , text changed
Directorystable/9/sys/netinet6/ip6_output.c modified , text changed
Directorystable/9/sys/netinet6/ip6_var.h modified , text changed

  ViewVC Help
Powered by ViewVC 1.1.27