[base] Log of /head/contrib/ntp/ntpd

Revision 362568 - Directory Listing
Modified Wed Jun 24 01:51:05 2020 UTC (4 years ago) by cy

MFV r362565:

Update 4.2.8p14 --> 4.2.8p15

Summary: Systems that use a CMAC algorithm in ntp.keys will not release
a bit of memory on each packet that uses a CMAC keyid, eventually causing
ntpd to run out of memory and fail. The CMAC cleanup from
https://bugs.ntp.org/3447, part of ntp-4.2.8p11, introduced a bug whereby
the CMAC data structure was no longer completely removed.

MFC after:	3 days
Security:	NTP Bug 3661

Revision 359676 - Directory Listing
Modified Mon Apr 6 23:11:43 2020 UTC (4 years, 2 months ago) by kevans

ntpd: fix build with -fno-common

Only a small nit here: psl should be declared extern and defined exactly
once.

-fno-common will become the default in GCC10/LLVM11.

MFC after:	3 days

Revision 358652 - Directory Listing
Modified Wed Mar 4 21:45:12 2020 UTC (4 years, 3 months ago) by cy

MFV r358616:

Update ntp-4.2.8p13 --> 4.2.8p14.

The advisory can be found at:
http://support.ntp.org/bin/view/Main/SecurityNotice#\
March_2020_ntp_4_2_8p14_NTP_Rele

No CVEs have been documented yet.

MFC after:	now
Security:	http://support.ntp.org/bin/view/Main/NtpBug3610
		http://support.ntp.org/bin/view/Main/NtpBug3596
		http://support.ntp.org/bin/view/Main/NtpBug3592

Revision 354733 - Directory Listing
Modified Fri Nov 15 16:34:35 2019 UTC (4 years, 7 months ago) by cy

Disable ntpd stack gap. When ASLR with STACK GAP != 0 ntpd suffers SIGSEGV.

PR:		241421, 241960
Reported by:	Vladimir Zakharov <zakharov.vv@gmail.com>,
		dewayne@heuristicsystems.com.au
Reviewed by:	kib, imp (previous version), ian (suggestion)
MFC after:	3 days
Differential Revision:	https://reviews.freebsd.org/D22358

Revision 352540 - Directory Listing
Modified Thu Sep 19 20:16:51 2019 UTC (4 years, 9 months ago) by cy

Follow up on r352304 which disabled default mlockall() at startup.
Unfortunately though the original tarball supports this in ./configure
(for Linux), to fully support disabling of mlockall() by default requires
a little extra help otherwise the following is logged in syslog:

	Cannot set RLIMIT_MEMLOCK: Operation not permitted

MFC after:	2 weeks
X-MFC with:	r352304

Revision 344883 - Directory Listing
Modified Thu Mar 7 13:36:00 2019 UTC (5 years, 3 months ago) by cy

MFV r344878:

4.2.8p12 --> 4.2.8p13

MFC after:	immediately
Security:	CVE-2019-8936
		VuXML: c2576e14-36e2-11e9-9eda-206a8a720317
Obtained from:	nwtime.org

Revision 336525 - Directory Listing
Modified Thu Jul 19 23:55:29 2018 UTC (5 years, 11 months ago) by ian

Make it possible to run ntpd as a non-root user, add ntpd uid and gid.

Code analysis and runtime analysis using truss(8) indicate that the only
privileged operations performed by ntpd are adjusting system time, and
(re-)binding to privileged UDP port 123. These changes add a new mac(4)
policy module, mac_ntpd(4), which grants just those privileges to any
process running with uid 123.

This also adds a new user and group, ntpd:ntpd, (uid:gid 123:123), and makes
them the owner of the /var/db/ntp directory, so that it can be used as a
location where the non-privileged daemon can write files such as the
driftfile, and any optional logfile or stats files.

Because there are so many ways to configure ntpd, the question of how to
configure it to run without root privs can be a bit complex, so that will be
addressed in a separate commit. These changes are just what's required to
grant the limited subset of privs to ntpd, and the small change to ntpd to
prevent it from exiting with an error if running as non-root.

Differential Revision:	https://reviews.freebsd.org/D16281

Revision 301247 - Directory Listing
Modified Fri Jun 3 08:00:22 2016 UTC (8 years, 1 month ago) by delphij

MFV r301238:

ntp 4.2.8p8.

Security:	CVE-2016-4957, CVE-2016-4953, CVE-2016-4954
Security:	CVE-2016-4955, CVE-2016-4956
Security:	FreeBSD-SA-16:24.ntp
With hat:	so

Revision 298695 - Directory Listing
Modified Wed Apr 27 07:46:38 2016 UTC (8 years, 2 months ago) by delphij

MFV r298691:

ntp 4.2.8p7.

Security:	CVE-2016-1547, CVE-2016-1548, CVE-2016-1549, CVE-2016-1550
Security:	CVE-2016-1551, CVE-2016-2516, CVE-2016-2517, CVE-2016-2518
Security:	CVE-2016-2519
Security:	FreeBSD-SA-16:16.ntp
With hat:	so

Revision 298123 - Directory Listing
Modified Sat Apr 16 18:10:11 2016 UTC (8 years, 2 months ago) by gjb

Remove the RCSID line from ntp_control.c, and set the fbsd:nokeywords
property.  This should have been done a while back (certainly before
mergeing projects/release-pkg to head), but I fixed the merge conflicts
and forgot to correct the real problem afterward.

Noticed by:	peter
Sponsored by:	The FreeBSD Foundation

Revision 298107 - Directory Listing
Modified Sat Apr 16 07:45:30 2016 UTC (8 years, 2 months ago) by gjb

Merge the projects/release-pkg branch to head.

This allows packaging the base system with pkg(8), including
but not limited to providing the ability to provide upstream
binary update possibilities for non-tier-1 architectures.

This merge is a requirement of the 11.0-RELEASE, and as such,
thank you to everyone that has tested the project branch.

Documentation in build(7) etc. is still somewhat sparse, but
updates to those parts will follow.

Sponsored by:	The FreeBSD Foundation

Revision 294554 - Directory Listing
Modified Fri Jan 22 07:32:39 2016 UTC (8 years, 5 months ago) by delphij

MFV r294491: ntp 4.2.8p6.

Security:	CVE-2015-7973, CVE-2015-7974, CVE-2015-7975
Security:	CVE-2015-7976, CVE-2015-7977, CVE-2015-7978
Security:	CVE-2015-7979, CVE-2015-8138, CVE-2015-8139
Security:	CVE-2015-8140, CVE-2015-8158
With hat:	so

Revision 289764 - Directory Listing
Modified Thu Oct 22 19:42:57 2015 UTC (8 years, 8 months ago) by glebius

MFV ntp-4.2.8p4 (r289715)

Security:       VuXML: c4a18a12-77fc-11e5-a687-206a8a720317
Security:	CVE-2015-7871
Security:	CVE-2015-7855
Security:	CVE-2015-7854
Security:	CVE-2015-7853
Security:	CVE-2015-7852
Security:	CVE-2015-7851
Security:	CVE-2015-7850
Security:	CVE-2015-7849
Security:	CVE-2015-7848
Security:	CVE-2015-7701
Security:	CVE-2015-7703
Security:	CVE-2015-7704, CVE-2015-7705
Security:	CVE-2015-7691, CVE-2015-7692, CVE-2015-7702
Security:	http://support.ntp.org/bin/view/Main/SecurityNotice#October_2015_NTP_Security_Vulner
Sponsored by:	Nginx, Inc.

Revision 285169 - Directory Listing
Modified Sun Jul 5 15:42:16 2015 UTC (9 years ago) by cy

MFV ntp-4.2.8p3 (r284990).

Approved by:	roberto, delphij
Security:	VuXML: 0d0f3050-1f69-11e5-9ba9-d050996490d0
Security:	http://bugs.ntp.org/show_bug.cgi?id=2853
Security:	https://www.kb.cert.org/vuls/id/668167
Security:	http://support.ntp.org/bin/view/Main/SecurityNotice#June_2015_NTP_Security_Vulnerabi

Revision 282408 - Directory Listing
Modified Mon May 4 04:45:59 2015 UTC (9 years, 2 months ago) by cy

MFV ntp 4.2.8p2 (r281348)

Reviewed by:    delphij (suggested MFC)
Approved by:	roberto
Security:       CVE-2015-1798, CVE-2015-1799
Security:       VuXML ebd84c96-dd7e-11e4-854e-3c970e169bc2
MFC after:	1 month

Revision 280849 - Directory Listing
Modified Mon Mar 30 13:30:15 2015 UTC (9 years, 3 months ago) by cy

MFV ntp 4.2.8p1 (r258945, r275970, r276091, r276092, r276093, r278284)

Thanks to roberto for providing pointers to wedge this into HEAD.

Approved by:	roberto

Revision 277202 - Directory Listing
Modified Wed Jan 14 23:34:00 2015 UTC (9 years, 5 months ago) by hiren

ntpd tries to bind to IPv6 interfaces in 'tentative' state and fails as IPv6 is
actually disabled. Fix it by making ntpd ignore such interfaces.

Submitted by:	ume
Reviewed by:	bz, gnn
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D1527

Revision 276071 - Directory Listing
Modified Mon Dec 22 18:54:55 2014 UTC (9 years, 6 months ago) by delphij

Fix multiple ntp vulnerabilities.

Reviewed by:	roberto (earlier revision), philip
Security:	CVE-2014-9293, CVE-2014-9294
Security:	CVE-2014-9295, CVE-2014-9296
Security:	FreeBSD-SA-14:31.ntp

Differential Revision: https://reviews.freebsd.org/D1343

Revision 243933 - Directory Listing
Modified Thu Dec 6 01:31:25 2012 UTC (11 years, 6 months ago) by eadler

Clean up hardcoded ar(1) flags in the tree to use the global ARFLAGS in
share/mk/sys.mk instead.

This is part of a medium term project to permit deterministic builds of
FreeBSD.

Submitted by:	Erik Cederstrand <erik@cederstrand.dk>
Reviewed by:	imp, toolchain@
Approved by:	cperciva
MFC after:	2 weeks

Revision 232844 - Directory Listing
Modified Mon Mar 12 01:06:29 2012 UTC (12 years, 3 months ago) by emaste

Remove extraneous log message

When ntp switched between PLL and FLL mode it produced a log message
"kernel time sync status change %04x".  This issue is reported in ntp
bug 452[1] which claims that this behaviour is normal and the log
message isn't necessary.  I'm not sure exactly when it was removed, but
it's gone in the latest ntp release (4.2.6p5).

[1] http://bugs.ntp.org/show_bug.cgi?id=452

Approved by:    roberto

Revision 223667 - Directory Listing
Modified Wed Jun 29 13:01:10 2011 UTC (13 years ago) by bz

In case ntp cannot resolve a hostname on startup it will queue the entry
for resolving by a child process that, upon success, will add the entry
to the config of the running running parent process.

Unfortunately there are a couple of bugs with this, fixed in various
later versions of upstream in potentially different ways due to other
code changes:

1) Upon server [-46] <FQDN> the [-46] are used as FQDN for later resolving
   which does not work.  Make sure we always pass the name (or IP there).

2) The intermediate file to carry the information to the child process
   does not know about -4/-6 restrictions, so that a dual-stacked host
   could resolve to an IPv6 address but that might be unreachable (see
   r223626) leading to no working synchronization ignoring a IPv4 record.
   Thus alter the intermediate format to also pass the address family
   (AF_UNSPEC (default), AF_INET or AF_INET6) to the child process
   depending on -4 or -6.

3) Make the child process to parse the new intermediate file format and
   save the address family for getaddrinfo() hints flags.

4) Change child to always reload resolv.conf calling res_init() before
   trying to resolve names.  This will pick up resolv.conf changes or
   new resolv.confs should they have not existed or been empty or
   unusable on ntp startup.  This fix is more conditional in upstream
   versions but given FreeBSD has res_init there is no need for the
   configure logic as well.

Approved by:	roberto
Sponsored by:	Sandvine Incorporated
MFC after:	9 days

Revision 223626 - Directory Listing
Modified Tue Jun 28 09:46:25 2011 UTC (13 years ago) by bz

Compare port numbers correctly.  They are stored by SRCPORT()
in host byte order, so we need to compare them as such.
Properly compare IPv6 addresses as well.

This allows the, by default, 8 badaddrs slots per address
family to work correctly and only print sendto() errors once.

The change is no longer applicable to any latest upstream versions.

Approved by:	roberto
Sponsored by:	Sandvine Incorporated
MFC after:	1 week

Revision 222444 - Directory Listing
Modified Sun May 29 07:40:48 2011 UTC (13 years, 1 month ago) by bz

The argument to setsockopt for IP_MULTICAST_LOOP depends on operating
system and is decided upon by configure and could be an u_int or a
u_char.  For FreeBSD it is a u_char.

For IPv6 however RFC 3493, 5.2 defines the argument to
IPV6_MULTICAST_LOOP to be an unsigned integer so make sure we always
use that using a second variable for the IPV6 case.
This is to get rid of these error messages every 5 minutes on some
systems:
ntpd[1530]: setsockopt IPV6_MULTICAST_LOOP failure: Invalid argument
  on socket 22, addr fe80::... for multicast address ff02::101

While here also fix the copy&paste error in the log message for
IPV6_MULTICAST_LOOP.

Reviewed by:	roberto
Sponsored by:	The FreeBSD Foundation
Sponsored by:	iXsystems
MFC after:	10 days
Filed as:	Bug 1936 on ntp.org

Revision 200576 - Directory Listing
Modified Tue Dec 15 14:58:10 2009 UTC (14 years, 6 months ago) by roberto

Merge 4.2.4p8 into contrib (r200452 & r200454).

Subversion is being difficult here so take a hammer and get it in.

MFC after:		2 weeks
Security:		CVE-2009-3563

Revision 199995 - Directory Listing
Modified Tue Dec 1 16:07:50 2009 UTC (14 years, 7 months ago) by ume

Don't try to bind to an anycast addeess.  The KAME IPv6 stack doesn't
allow bind to an anycast addeess.  It does away with an annoying
message.

Reviewed by:	bz, roberto
MFC after:	2 weeks

Revision 193893 - Directory Listing
Modified Wed Jun 10 10:31:11 2009 UTC (15 years ago) by cperciva

Prevent integer overflow in direct pipe write code from circumventing
virtual-to-physical page lookups. [09:09]

Add missing permissions check for SIOCSIFINFO_IN6 ioctl. [09:10]

Fix buffer overflow in "autokey" negotiation in ntpd(8). [09:11]

Approved by:	so (cperciva)
Approved by:	re (not really, but SVN wants this...)
Security:	FreeBSD-SA-09:09.pipe
Security:	FreeBSD-SA-09:10.ipv6
Security:	FreeBSD-SA-09:11.ntpd

Revision 187194 - Directory Listing
Modified Tue Jan 13 21:19:27 2009 UTC (15 years, 5 months ago) by simon

Correct ntpd(8) cryptographic signature bypass [SA-09:04].

Correct BIND DNSSEC incorrect checks for malformed signatures
[SA-09:04].

Security:	FreeBSD-SA-09:03.ntpd
Security:	FreeBSD-SA-09:04.bind
Obtained from:	ISC [SA-09:04]
Approved by:	so (simon)

Revision 182007 - Directory Listing
Modified Fri Aug 22 15:58:00 2008 UTC (15 years, 10 months ago) by roberto

Merge ntpd & friends 4.2.4p5 from vendor/ntp/dist into head.  Next commit
will update usr.sbin/ntp to match this.

MFC after:	2 weeks

Revision 132455 - Directory Listing
Modified Tue Jul 20 15:18:31 2004 UTC (19 years, 11 months ago) by roberto

Merge conflicts (see also previous commit).

Reinsert our local changes to ntp_control.c:

1.4:    Do not log every potential exploit attempt since a denial-of-service
        may result
1.5:    int -> unsigned char fixes

Revision 132452 - Directory Listing
Modified Tue Jul 20 15:01:56 2004 UTC (19 years, 11 months ago) by roberto

This commit was generated by cvs2svn to compensate for changes in r132451,
which included commits to RCS files with non-trunk default branches.

Revision 106425 - Directory Listing
Modified Mon Nov 4 19:36:11 2002 UTC (21 years, 8 months ago) by roberto

This commit was generated by cvs2svn to compensate for changes in r106424,
which included commits to RCS files with non-trunk default branches.

Revision 106164 - Directory Listing
Modified Tue Oct 29 19:58:12 2002 UTC (21 years, 8 months ago) by roberto

This commit was generated by cvs2svn to compensate for changes in r106163,
which included commits to RCS files with non-trunk default branches.

Revision 82502 - Directory Listing
Modified Wed Aug 29 15:01:06 2001 UTC (22 years, 10 months ago) by roberto

Redo the int ->  unsigned changes jedgar did. It should have been submitted
back but it was off the vendor branch anyway so...

Revision 82499 - Directory Listing
Modified Wed Aug 29 14:35:15 2001 UTC (22 years, 10 months ago) by roberto

This commit was generated by cvs2svn to compensate for changes in r82498,
which included commits to RCS files with non-trunk default branches.

Revision 75259 - Directory Listing
Modified Fri Apr 6 14:15:38 2001 UTC (23 years, 3 months ago) by jedgar

- Correct off-by-one error and buffer underflow from previous fix
- int -> unsigned char fixes

Submitted by:	ache, dillon, Mark Andrews, et.al. (on -security)

Revision 57739 - Directory Listing
Modified Fri Mar 3 17:06:31 2000 UTC (24 years, 4 months ago) by roberto

This commit was generated by cvs2svn to compensate for changes in r57738,
which included commits to RCS files with non-trunk default branches.

Revision 56747 - Directory Listing
Modified Fri Jan 28 14:55:50 2000 UTC (24 years, 5 months ago) by roberto

This commit was generated by cvs2svn to compensate for changes in r56746,
which included commits to RCS files with non-trunk default branches.

Revision 54363 - Directory Listing
Modified Thu Dec 9 13:17:01 1999 UTC (24 years, 6 months ago) by roberto

Commit a fix several warnings on alpha for sysctlbyname arguments. It could
have resulted in stack corruption. A patch has been sent to the ntp author
for inclusion in next version.

Obtained from:	peter

Revision 54360 - Directory Listing
Added Thu Dec 9 13:01:21 1999 UTC (24 years, 6 months ago) by roberto

This commit was generated by cvs2svn to compensate for changes in r54359,
which included commits to RCS files with non-trunk default branches.

	ViewVC Help
Powered by ViewVC 1.1.27